Fix non-text content using own_window_argb_value
#2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tin Švagelj <[email protected]>
github-actions
bot
added
sources
✅ Deploy Preview for conkyweb canceled.
|
Caellian
added
bug
Caellian
commented
Dec 7, 2024
Comment on lines
-787
to
-789
| #ifdef BUILD_ARGB | ||
| current_color.alpha = own_window_argb_value.get(*state); | ||
| #endif /* BUILD_ARGB */ |
There was a problem hiding this comment.
Transparent bars caused by this.
Comment on lines
-929
to
+928
| cairo_set_operator(window->cr, CAIRO_OPERATOR_SOURCE); | ||
| cairo_paint(window->cr); | ||
| cairo_set_operator(window->cr, CAIRO_OPERATOR_CLEAR); | ||
| cairo_rectangle(window->cr, 0, 0, window->rectangle.width(), | ||
| window->rectangle.height()); |
There was a problem hiding this comment.
This seems more correct - SO answer.
Resetting to OVER isn't needed because of cairo_restore.
Caellian
changed the title
own_window_argb_value
brndnmtthws
approved these changes
Dec 8, 2024
|
#2127 fixes omission of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1504.
own_window_argb_valueshouldn't control content color.Also fixed
clear_textusing a wrong cairo operator.Tested on hyprland.